Skip to content

Thumbnails: record disproven approaches, precise engine spec; keep colored cells - #8

Merged
proggeramlug merged 1 commit into
mainfrom
chore/thumbnail-findings
Jul 17, 2026
Merged

Thumbnails: record disproven approaches, precise engine spec; keep colored cells#8
proggeramlug merged 1 commit into
mainfrom
chore/thumbnail-findings

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

See commit message — two screenshot-disproven approaches documented in code + PLAN, engine work scoped to renderModelToTexture + a drawTexturePro round-trip golden test. 158 unit + ui-smoke green.

https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K

…pe the engine work precisely

Two editor-side attempts at real thumbnails are now screenshot-disproven:
mid-frame texture mode (the override is per-frame, consumed at end_frame)
and dedicated whole frames (pipeline engages — GI backend re-selects —
but the texture still draws as NOTHING via drawTexturePro; even a bare
magenta clear never shows). The engine feature is now precisely scoped:
a self-contained renderModelToTexture pass + a golden test that round-
trips a rendered texture through drawTexturePro, which today has never
successfully sampled an RT texture.

The asset grid keeps its category-colored cells; the dedicated-frame
scaffolding (world hide/unhide, framing camera, burst loop) stays in git
history for the day the engine call exists.

158 unit tests + ui-smoke pass.

Claude-Session: https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K
@proggeramlug
proggeramlug merged commit be91dbf into main Jul 17, 2026
@proggeramlug
proggeramlug deleted the chore/thumbnail-findings branch July 17, 2026 11:03
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proggeramlug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: df7e26a7-21f2-40c1-b9aa-0ad59ac91d0e

📥 Commits

Reviewing files that changed from the base of the PR and between cf9ce2a and ec87369.

📒 Files selected for processing (3)
  • PLAN.md
  • src/main.ts
  • src/ui/thumbnails.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/thumbnail-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant